lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

MSI: Simplify BUG() handling in msi_remove_pci_irq_vectors() part 1

Browse Source 
Although it might be nice to do a printk before BUG'ing, it's really not
necessary, and it complicates the code.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Michael Ellerman
2007-03-22 21:51:31 +11:00
committed by Greg Kroah-Hartman
parent 54bc6c0b0e
commit c31af39870
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/pci/msi.c
View File

@@ -719,12 +719,7 @@ void msi_remove_pci_irq_vectors(struct pci_dev* dev)
return; return;
if (dev->msi_enabled) { if (dev->msi_enabled) {
if (irq_has_action(dev->first_msi_irq)) {
printk(KERN_WARNING "PCI: %s: msi_remove_pci_irq_vectors() "
"called without free_irq() on MSI irq %d\n",
pci_name(dev), dev->first_msi_irq);
BUG_ON(irq_has_action(dev->first_msi_irq)); BUG_ON(irq_has_action(dev->first_msi_irq));
} else /* Release MSI irq assigned to this device */
msi_free_irq(dev, dev->first_msi_irq); msi_free_irq(dev, dev->first_msi_irq);
} }
if (dev->msix_enabled) { if (dev->msix_enabled) {