lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[media] cx23885: Remove useless struct i2c_algo_bit_data

Browse Source 
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.

Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Ezequiel García
2012-06-27 12:52:47 -03:00
committed by Mauro Carvalho Chehab
parent 6fe31039d4
commit c410d09bf3
3 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/video/cx23885/cx23885-i2c.c
View File

@@ -318,8 +318,6 @@ int cx23885_i2c_register(struct cx23885_i2c *bus)
memcpy(&bus->i2c_adap, &cx23885_i2c_adap_template, memcpy(&bus->i2c_adap, &cx23885_i2c_adap_template,
sizeof(bus->i2c_adap)); sizeof(bus->i2c_adap));
memcpy(&bus->i2c_algo, &cx23885_i2c_algo_template,
sizeof(bus->i2c_algo));
memcpy(&bus->i2c_client, &cx23885_i2c_client_template, memcpy(&bus->i2c_client, &cx23885_i2c_client_template,
sizeof(bus->i2c_client)); sizeof(bus->i2c_client));
@@ -328,7 +326,6 @@ int cx23885_i2c_register(struct cx23885_i2c *bus)
strlcpy(bus->i2c_adap.name, bus->dev->name, strlcpy(bus->i2c_adap.name, bus->dev->name,
sizeof(bus->i2c_adap.name)); sizeof(bus->i2c_adap.name));
bus->i2c_algo.data = bus;
bus->i2c_adap.algo_data = bus; bus->i2c_adap.algo_data = bus;
i2c_set_adapdata(&bus->i2c_adap, &dev->v4l2_dev); i2c_set_adapdata(&bus->i2c_adap, &dev->v4l2_dev);
i2c_add_adapter(&bus->i2c_adap); i2c_add_adapter(&bus->i2c_adap);

2
drivers/media/video/cx23885/cx23885.h
View File

@@ -21,7 +21,6 @@
#include <linux/pci.h> #include <linux/pci.h>
#include <linux/i2c.h> #include <linux/i2c.h>
#include <linux/i2c-algo-bit.h>
#include <linux/kdev_t.h> #include <linux/kdev_t.h>
#include <linux/slab.h> #include <linux/slab.h>
@@ -247,7 +246,6 @@ struct cx23885_i2c {
/* i2c i/o */ /* i2c i/o */
struct i2c_adapter i2c_adap; struct i2c_adapter i2c_adap;
struct i2c_algo_bit_data i2c_algo;
struct i2c_client i2c_client; struct i2c_client i2c_client;
u32 i2c_rc; u32 i2c_rc;

1
drivers/media/video/saa7164/saa7164.h
View File

@@ -46,7 +46,6 @@
#include <linux/pci.h> #include <linux/pci.h>
#include <linux/i2c.h> #include <linux/i2c.h>
#include <linux/i2c-algo-bit.h>
#include <linux/kdev_t.h> #include <linux/kdev_t.h>
#include <linux/mutex.h> #include <linux/mutex.h>
#include <linux/crc32.h> #include <linux/crc32.h>