Various drivers' irq handlers: kill dead code, needless casts
- Eliminate casts to/from void* - Eliminate checks for conditions that never occur. These typically fall into two classes: 1) Checking for 'dev_id == NULL', then it is never called with NULL as an argument. 2) Checking for invalid irq number, when the only caller (the system) guarantees the irq handler is called with the proper 'irq' number argument. Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
@ -862,15 +862,10 @@ static inline void interrupts_off (amb_dev * dev) {
|
||||
/********** interrupt handling **********/
|
||||
|
||||
static irqreturn_t interrupt_handler(int irq, void *dev_id) {
|
||||
amb_dev * dev = (amb_dev *) dev_id;
|
||||
amb_dev * dev = dev_id;
|
||||
|
||||
PRINTD (DBG_IRQ|DBG_FLOW, "interrupt_handler: %p", dev_id);
|
||||
|
||||
if (!dev_id) {
|
||||
PRINTD (DBG_IRQ|DBG_ERR, "irq with NULL dev_id: %d", irq);
|
||||
return IRQ_NONE;
|
||||
}
|
||||
|
||||
{
|
||||
u32 interrupt = rd_plain (dev, offsetof(amb_mem, interrupt));
|
||||
|
||||
|
Reference in New Issue
Block a user