lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SCSI] sym53c416: fix module parameters

Browse Source 
It looks like there's been a bug in the module parameter setup forever.
The upshot doesn't really matter, because even if no parameters are ever
set, we just call sym53c416_setup() three times, but the zero values in
the arrays eventually cause nothing to happen.  Unfortunately gcc has
started to notice this now too:

drivers/scsi/sym53c416.c: In function 'sym53c416_detect':
drivers/scsi/sym53c416.c:624: warning: the address of 'sym53c416' will always evaluate as 'true'
drivers/scsi/sym53c416.c:630: warning: the address of 'sym53c416_1' will always evaluate as 'true'
drivers/scsi/sym53c416.c:636: warning: the address of 'sym53c416_2' will always evaluate as 'true'
drivers/scsi/sym53c416.c:642: warning: the address of 'sym53c416_3' will always evaluate as 'true'

So fix this longstanding bug to keep gcc quiet.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
James Bottomley
2008-02-11 16:18:55 -06:00
parent e390bc0a26
commit c958d767dc
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/scsi/sym53c416.c
View File

@@ -187,10 +187,10 @@
#define sym53c416_base_2 sym53c416_2 #define sym53c416_base_2 sym53c416_2
#define sym53c416_base_3 sym53c416_3 #define sym53c416_base_3 sym53c416_3
static unsigned int sym53c416_base[2] = {0,0}; static unsigned int sym53c416_base[2];
static unsigned int sym53c416_base_1[2] = {0,0}; static unsigned int sym53c416_base_1[2];
static unsigned int sym53c416_base_2[2] = {0,0}; static unsigned int sym53c416_base_2[2];
static unsigned int sym53c416_base_3[2] = {0,0}; static unsigned int sym53c416_base_3[2];
#endif #endif
@@ -621,25 +621,25 @@ int __init sym53c416_detect(struct scsi_host_template *tpnt)
int ints[3]; int ints[3];
ints[0] = 2; ints[0] = 2;
if(sym53c416_base) if(sym53c416_base[0])
{ {
ints[1] = sym53c416_base[0]; ints[1] = sym53c416_base[0];
ints[2] = sym53c416_base[1]; ints[2] = sym53c416_base[1];
sym53c416_setup(NULL, ints); sym53c416_setup(NULL, ints);
} }
if(sym53c416_base_1) if(sym53c416_base_1[0])
{ {
ints[1] = sym53c416_base_1[0]; ints[1] = sym53c416_base_1[0];
ints[2] = sym53c416_base_1[1]; ints[2] = sym53c416_base_1[1];
sym53c416_setup(NULL, ints); sym53c416_setup(NULL, ints);
} }
if(sym53c416_base_2) if(sym53c416_base_2[0])
{ {
ints[1] = sym53c416_base_2[0]; ints[1] = sym53c416_base_2[0];
ints[2] = sym53c416_base_2[1]; ints[2] = sym53c416_base_2[1];
sym53c416_setup(NULL, ints); sym53c416_setup(NULL, ints);
} }
if(sym53c416_base_3) if(sym53c416_base_3[0])
{ {
ints[1] = sym53c416_base_3[0]; ints[1] = sym53c416_base_3[0];
ints[2] = sym53c416_base_3[1]; ints[2] = sym53c416_base_3[1];