lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

NET: bna, fix lock imbalance

Browse Source 
bnad_set_rx_mode omit to unlock bna_lock on one fail path. Fix that.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Debashis Dutt <ddutt@brocade.com>
Cc: Rasesh Mody <rmody@brocade.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jiri Slaby
2010-09-04 02:08:41 +00:00
committed by David S. Miller
parent e8f7f43a4a
commit ca1cef3a3a
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/bna/bnad.c
View File

@@ -2702,7 +2702,7 @@ bnad_set_rx_mode(struct net_device *netdev)
kzalloc((mc_count + 1) * ETH_ALEN, kzalloc((mc_count + 1) * ETH_ALEN,
GFP_ATOMIC); GFP_ATOMIC);
if (!mcaddr_list) if (!mcaddr_list)
return; goto unlock;
memcpy(&mcaddr_list[0], &bnad_bcast_addr[0], ETH_ALEN); memcpy(&mcaddr_list[0], &bnad_bcast_addr[0], ETH_ALEN);
@@ -2715,6 +2715,7 @@ bnad_set_rx_mode(struct net_device *netdev)
/* Should we enable BNAD_CF_ALLMULTI for err != 0 ? */ /* Should we enable BNAD_CF_ALLMULTI for err != 0 ? */
kfree(mcaddr_list); kfree(mcaddr_list);
} }
unlock:
spin_unlock_irqrestore(&bnad->bna_lock, flags); spin_unlock_irqrestore(&bnad->bna_lock, flags);
} }