lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

x86: Work around compiler code generation bug with -Os

Browse Source 
Some versions of gcc generate incorrect code for the inet_check_attr()
function, apparently due to a totally bogus index -> pointer comparison
transformation.

At least "gcc version 4.0.1 20050727 (Red Hat 4.0.1-5)" from FC4 is
affected, possibly others too.

This changes the function subtly so that the buggy gcc transformation
doesn't trigger.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Linus Torvalds
2006-01-14 22:08:28 -08:00
parent 650eec5e04
commit caf5b04c82
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
net/ipv4/fib_frontend.c
View File

@@ -289,13 +289,13 @@ static int inet_check_attr(struct rtmsg *r, struct rtattr **rta)
{ {
int i; int i;
for (i=1; i<=RTA_MAX; i++) { for (i=1; i<=RTA_MAX; i++, rta++) {
struct rtattr *attr = rta[i-1]; struct rtattr *attr = *rta;
if (attr) { if (attr) {
if (RTA_PAYLOAD(attr) < 4) if (RTA_PAYLOAD(attr) < 4)
return -EINVAL; return -EINVAL;
if (i != RTA_MULTIPATH && i != RTA_METRICS) if (i != RTA_MULTIPATH && i != RTA_METRICS)
rta[i-1] = (struct rtattr*)RTA_DATA(attr); *rta = (struct rtattr*)RTA_DATA(attr);
} }
} }
return 0; return 0;