ASoC: DaVinci: Fix audio stall when doing full duplex
Fix concurrent capture/playback issue. The issue is caused by re-initialization of control registers used specifically for capture or playback in both capture and playback operations. Signed-off-by: Steve Chen <schen@mvista.com> Signed-off-by: Naresh Medisetty <naresh@ti.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
committed by
Mark Brown
parent
8d702f2376
commit
cb6e206369
@@ -295,10 +295,14 @@ static int davinci_i2s_hw_params(struct snd_pcm_substream *substream,
|
|||||||
u32 w;
|
u32 w;
|
||||||
|
|
||||||
/* general line settings */
|
/* general line settings */
|
||||||
davinci_mcbsp_write_reg(dev, DAVINCI_MCBSP_SPCR_REG,
|
w = davinci_mcbsp_read_reg(dev, DAVINCI_MCBSP_SPCR_REG);
|
||||||
DAVINCI_MCBSP_SPCR_RINTM(3) |
|
if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
|
||||||
DAVINCI_MCBSP_SPCR_XINTM(3) |
|
w |= DAVINCI_MCBSP_SPCR_RINTM(3) | DAVINCI_MCBSP_SPCR_FREE;
|
||||||
DAVINCI_MCBSP_SPCR_FREE);
|
davinci_mcbsp_write_reg(dev, DAVINCI_MCBSP_SPCR_REG, w);
|
||||||
|
} else {
|
||||||
|
w |= DAVINCI_MCBSP_SPCR_XINTM(3) | DAVINCI_MCBSP_SPCR_FREE;
|
||||||
|
davinci_mcbsp_write_reg(dev, DAVINCI_MCBSP_SPCR_REG, w);
|
||||||
|
}
|
||||||
|
|
||||||
i = hw_param_interval(params, SNDRV_PCM_HW_PARAM_SAMPLE_BITS);
|
i = hw_param_interval(params, SNDRV_PCM_HW_PARAM_SAMPLE_BITS);
|
||||||
w = davinci_mcbsp_read_reg(dev, DAVINCI_MCBSP_SRGR_REG);
|
w = davinci_mcbsp_read_reg(dev, DAVINCI_MCBSP_SRGR_REG);
|
||||||
@@ -329,16 +333,19 @@ static int davinci_i2s_hw_params(struct snd_pcm_substream *substream,
|
|||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
|
||||||
w = davinci_mcbsp_read_reg(dev, DAVINCI_MCBSP_RCR_REG);
|
w = davinci_mcbsp_read_reg(dev, DAVINCI_MCBSP_RCR_REG);
|
||||||
MOD_REG_BIT(w, DAVINCI_MCBSP_RCR_RWDLEN1(mcbsp_word_length) |
|
MOD_REG_BIT(w, DAVINCI_MCBSP_RCR_RWDLEN1(mcbsp_word_length) |
|
||||||
DAVINCI_MCBSP_RCR_RWDLEN2(mcbsp_word_length), 1);
|
DAVINCI_MCBSP_RCR_RWDLEN2(mcbsp_word_length), 1);
|
||||||
davinci_mcbsp_write_reg(dev, DAVINCI_MCBSP_RCR_REG, w);
|
davinci_mcbsp_write_reg(dev, DAVINCI_MCBSP_RCR_REG, w);
|
||||||
|
|
||||||
|
} else {
|
||||||
w = davinci_mcbsp_read_reg(dev, DAVINCI_MCBSP_XCR_REG);
|
w = davinci_mcbsp_read_reg(dev, DAVINCI_MCBSP_XCR_REG);
|
||||||
MOD_REG_BIT(w, DAVINCI_MCBSP_XCR_XWDLEN1(mcbsp_word_length) |
|
MOD_REG_BIT(w, DAVINCI_MCBSP_XCR_XWDLEN1(mcbsp_word_length) |
|
||||||
DAVINCI_MCBSP_XCR_XWDLEN2(mcbsp_word_length), 1);
|
DAVINCI_MCBSP_XCR_XWDLEN2(mcbsp_word_length), 1);
|
||||||
davinci_mcbsp_write_reg(dev, DAVINCI_MCBSP_XCR_REG, w);
|
davinci_mcbsp_write_reg(dev, DAVINCI_MCBSP_XCR_REG, w);
|
||||||
|
|
||||||
|
}
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user