lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

usbatm: fix tiny race

Browse Source 
If usbatm_do_heavy_init finishes before usbatm_heavy_init
writes the pid, the disconnect method could shoot down the
wrong process if the pid has been recycled.

Signed-off-by: Duncan Sands <baldrick@free.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Duncan Sands
2006-10-05 09:56:44 +02:00
committed by Greg Kroah-Hartman
parent e4a20daa7b
commit ccf40d62c7
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/atm/usbatm.c
View File

@@ -1001,6 +1001,7 @@ static int usbatm_do_heavy_init(void *arg)
daemonize(instance->driver->driver_name); daemonize(instance->driver->driver_name);
allow_signal(SIGTERM); allow_signal(SIGTERM);
instance->thread_pid = get_current()->pid;
complete(&instance->thread_started); complete(&instance->thread_started);
@@ -1025,10 +1026,6 @@ static int usbatm_heavy_init(struct usbatm_data *instance)
return ret; return ret;
} }
mutex_lock(&instance->serialize);
instance->thread_pid = ret;
mutex_unlock(&instance->serialize);
wait_for_completion(&instance->thread_started); wait_for_completion(&instance->thread_started);
return 0; return 0;