lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: backlight, appledisplay: fix incomplete registration failure handling

Browse Source 
On error while registering backlight, return it to caller instead of
returning 0.
Mark struct backlight_ops as const.

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Bruno Prémont
2010-02-26 13:02:04 +01:00
committed by Greg Kroah-Hartman
parent 124d255382
commit cedf8a7842
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/misc/appledisplay.c
View File

@@ -179,7 +179,7 @@ static int appledisplay_bl_get_brightness(struct backlight_device *bd)
return pdata->msgdata[1]; return pdata->msgdata[1];
} }
static struct backlight_ops appledisplay_bl_data = { static const struct backlight_ops appledisplay_bl_data = {
.get_brightness = appledisplay_bl_get_brightness, .get_brightness = appledisplay_bl_get_brightness,
.update_status = appledisplay_bl_update_status, .update_status = appledisplay_bl_update_status,
}; };
@@ -283,6 +283,7 @@ static int appledisplay_probe(struct usb_interface *iface,
&appledisplay_bl_data); &appledisplay_bl_data);
if (IS_ERR(pdata->bd)) { if (IS_ERR(pdata->bd)) {
dev_err(&iface->dev, "Backlight registration failed\n"); dev_err(&iface->dev, "Backlight registration failed\n");
retval = PTR_ERR(pdata->bd);
goto error; goto error;
} }