lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ath6kl: fix atomicity in ath6kl_cfg80211_scan_node()

Browse Source 
ath6kl_cfg80211_scan_node() was calling cfg80211_inform_bss_frame()
with CFP_KERNEL but the function is executed with a spin lock taken.
This is wrong and the function must use GFP_ATOMIC instead.

Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
This commit is contained in:
Kalle Valo
2011-07-21 10:04:54 +03:00
parent b2c76bbe00
commit cf104c2a20
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/wireless/ath/ath6kl/cfg80211.c
View File

@@ -720,6 +720,7 @@ static inline bool is_ch_11a(u16 ch)
return (!((ch >= 2412) && (ch <= 2484))); return (!((ch >= 2412) && (ch <= 2484)));
} }
/* struct ath6kl_node_table::nt_nodelock is locked when calling this */
static void ath6kl_cfg80211_scan_node(void *arg, struct bss *ni) static void ath6kl_cfg80211_scan_node(void *arg, struct bss *ni)
{ {
struct wiphy *wiphy = (struct wiphy *)arg; struct wiphy *wiphy = (struct wiphy *)arg;
@@ -769,7 +770,7 @@ static void ath6kl_cfg80211_scan_node(void *arg, struct bss *ni)
"%s: bssid %pM ch %d freq %d size %d\n", __func__, "%s: bssid %pM ch %d freq %d size %d\n", __func__,
mgmt->bssid, channel->hw_value, freq, size); mgmt->bssid, channel->hw_value, freq, size);
cfg80211_inform_bss_frame(wiphy, channel, mgmt, cfg80211_inform_bss_frame(wiphy, channel, mgmt,
size, signal, GFP_KERNEL); size, signal, GFP_ATOMIC);
kfree(ieeemgmtbuf); kfree(ieeemgmtbuf);
} }