[NETFILTER]: x_tables: switch hotdrop to bool
Switch the "hotdrop" variables to boolean Signed-off-by: Jan Engelhardt <jengelh@gmx.de> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
7bfe246116
commit
cff533ac12
@@ -23,7 +23,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protooff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
/* We always match */
|
||||
return 1;
|
||||
|
@@ -23,7 +23,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_connbytes_info *sinfo = matchinfo;
|
||||
struct nf_conn *ct;
|
||||
|
@@ -38,7 +38,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_connmark_info *info = matchinfo;
|
||||
struct nf_conn *ct;
|
||||
|
@@ -27,7 +27,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_conntrack_info *sinfo = matchinfo;
|
||||
struct nf_conn *ct;
|
||||
|
@@ -36,7 +36,7 @@ dccp_find_option(u_int8_t option,
|
||||
const struct sk_buff *skb,
|
||||
unsigned int protoff,
|
||||
const struct dccp_hdr *dh,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
/* tcp.doff is only 4 bits, ie. max 15 * 4 bytes */
|
||||
unsigned char *op;
|
||||
@@ -45,7 +45,7 @@ dccp_find_option(u_int8_t option,
|
||||
unsigned int i;
|
||||
|
||||
if (dh->dccph_doff * 4 < __dccp_hdr_len(dh)) {
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -57,7 +57,7 @@ dccp_find_option(u_int8_t option,
|
||||
if (op == NULL) {
|
||||
/* If we don't have the whole header, drop packet. */
|
||||
spin_unlock_bh(&dccp_buflock);
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -86,7 +86,7 @@ match_types(const struct dccp_hdr *dh, u_int16_t typemask)
|
||||
|
||||
static inline int
|
||||
match_option(u_int8_t option, const struct sk_buff *skb, unsigned int protoff,
|
||||
const struct dccp_hdr *dh, int *hotdrop)
|
||||
const struct dccp_hdr *dh, bool *hotdrop)
|
||||
{
|
||||
return dccp_find_option(option, skb, protoff, dh, hotdrop);
|
||||
}
|
||||
@@ -99,7 +99,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_dccp_info *info = matchinfo;
|
||||
struct dccp_hdr _dh, *dh;
|
||||
@@ -109,7 +109,7 @@ match(const struct sk_buff *skb,
|
||||
|
||||
dh = skb_header_pointer(skb, protoff, sizeof(_dh), &_dh);
|
||||
if (dh == NULL) {
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@@ -29,7 +29,7 @@ static int match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_dscp_info *info = matchinfo;
|
||||
u_int8_t dscp = ipv4_get_dsfield(ip_hdr(skb)) >> XT_DSCP_SHIFT;
|
||||
@@ -44,7 +44,7 @@ static int match6(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_dscp_info *info = matchinfo;
|
||||
u_int8_t dscp = ipv6_get_dsfield(ipv6_hdr(skb)) >> XT_DSCP_SHIFT;
|
||||
|
@@ -50,7 +50,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
struct ip_esp_hdr _esp, *eh;
|
||||
const struct xt_esp *espinfo = matchinfo;
|
||||
@@ -65,7 +65,7 @@ match(const struct sk_buff *skb,
|
||||
* can't. Hence, no choice but to drop.
|
||||
*/
|
||||
duprintf("Dropping evil ESP tinygram.\n");
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@@ -440,7 +440,7 @@ hashlimit_match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
struct xt_hashlimit_info *r =
|
||||
((struct xt_hashlimit_info *)matchinfo)->u.master;
|
||||
@@ -487,7 +487,7 @@ hashlimit_match(const struct sk_buff *skb,
|
||||
return 0;
|
||||
|
||||
hotdrop:
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@@ -36,7 +36,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_helper_info *info = matchinfo;
|
||||
struct nf_conn *ct;
|
||||
|
@@ -28,7 +28,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_length_info *info = matchinfo;
|
||||
u_int16_t pktlen = ntohs(ip_hdr(skb)->tot_len);
|
||||
@@ -44,7 +44,7 @@ match6(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_length_info *info = matchinfo;
|
||||
const u_int16_t pktlen = (ntohs(ipv6_hdr(skb)->payload_len) +
|
||||
|
@@ -65,7 +65,7 @@ ipt_limit_match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
struct xt_rateinfo *r = ((struct xt_rateinfo *)matchinfo)->master;
|
||||
unsigned long now = jiffies;
|
||||
|
@@ -32,7 +32,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_mac_info *info = matchinfo;
|
||||
|
||||
|
@@ -27,7 +27,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_mark_info *info = matchinfo;
|
||||
|
||||
|
@@ -102,7 +102,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
__be16 _ports[2], *pptr;
|
||||
const struct xt_multiport *multiinfo = matchinfo;
|
||||
@@ -116,7 +116,7 @@ match(const struct sk_buff *skb,
|
||||
* can't. Hence, no choice but to drop.
|
||||
*/
|
||||
duprintf("xt_multiport: Dropping evil offset=0 tinygram.\n");
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -133,7 +133,7 @@ match_v1(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
__be16 _ports[2], *pptr;
|
||||
const struct xt_multiport_v1 *multiinfo = matchinfo;
|
||||
@@ -147,7 +147,7 @@ match_v1(const struct sk_buff *skb,
|
||||
* can't. Hence, no choice but to drop.
|
||||
*/
|
||||
duprintf("xt_multiport: Dropping evil offset=0 tinygram.\n");
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@@ -31,7 +31,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
int i;
|
||||
static const char nulldevname[IFNAMSIZ];
|
||||
|
@@ -28,7 +28,7 @@ static int match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
u_int8_t type;
|
||||
const struct xt_pkttype_info *info = matchinfo;
|
||||
|
@@ -115,7 +115,7 @@ static int match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_policy_info *info = matchinfo;
|
||||
int ret;
|
||||
|
@@ -20,7 +20,7 @@ static int
|
||||
match(const struct sk_buff *skb,
|
||||
const struct net_device *in, const struct net_device *out,
|
||||
const struct xt_match *match, const void *matchinfo,
|
||||
int offset, unsigned int protoff, int *hotdrop)
|
||||
int offset, unsigned int protoff, bool *hotdrop)
|
||||
{
|
||||
struct xt_quota_info *q = ((struct xt_quota_info *)matchinfo)->master;
|
||||
int ret = q->flags & XT_QUOTA_INVERT ? 1 : 0;
|
||||
|
@@ -29,7 +29,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_realm_info *info = matchinfo;
|
||||
struct dst_entry *dst = skb->dst;
|
||||
|
@@ -47,7 +47,7 @@ match_packet(const struct sk_buff *skb,
|
||||
int chunk_match_type,
|
||||
const struct xt_sctp_flag_info *flag_info,
|
||||
const int flag_count,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
u_int32_t chunkmapcopy[256 / sizeof (u_int32_t)];
|
||||
sctp_chunkhdr_t _sch, *sch;
|
||||
@@ -64,7 +64,7 @@ match_packet(const struct sk_buff *skb,
|
||||
sch = skb_header_pointer(skb, offset, sizeof(_sch), &_sch);
|
||||
if (sch == NULL || sch->length == 0) {
|
||||
duprintf("Dropping invalid SCTP packet.\n");
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -127,7 +127,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_sctp_info *info = matchinfo;
|
||||
sctp_sctphdr_t _sh, *sh;
|
||||
@@ -140,7 +140,7 @@ match(const struct sk_buff *skb,
|
||||
sh = skb_header_pointer(skb, protoff, sizeof(_sh), &_sh);
|
||||
if (sh == NULL) {
|
||||
duprintf("Dropping evil TCP offset=0 tinygram.\n");
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
duprintf("spt: %d\tdpt: %d\n", ntohs(sh->source), ntohs(sh->dest));
|
||||
|
@@ -28,7 +28,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_state_info *sinfo = matchinfo;
|
||||
enum ip_conntrack_info ctinfo;
|
||||
|
@@ -28,7 +28,7 @@ static int
|
||||
match(const struct sk_buff *skb,
|
||||
const struct net_device *in, const struct net_device *out,
|
||||
const struct xt_match *match, const void *matchinfo,
|
||||
int offset, unsigned int protoff, int *hotdrop)
|
||||
int offset, unsigned int protoff, bool *hotdrop)
|
||||
{
|
||||
struct xt_statistic_info *info = (struct xt_statistic_info *)matchinfo;
|
||||
int ret = info->flags & XT_STATISTIC_INVERT ? 1 : 0;
|
||||
|
@@ -28,7 +28,7 @@ static int match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_string_info *conf = matchinfo;
|
||||
struct ts_state state;
|
||||
|
@@ -31,7 +31,7 @@ match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
const struct xt_tcpmss_match_info *info = matchinfo;
|
||||
struct tcphdr _tcph, *th;
|
||||
@@ -77,7 +77,7 @@ out:
|
||||
return info->invert;
|
||||
|
||||
dropit:
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@@ -42,7 +42,7 @@ tcp_find_option(u_int8_t option,
|
||||
unsigned int protoff,
|
||||
unsigned int optlen,
|
||||
int invert,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
/* tcp.doff is only 4 bits, ie. max 15 * 4 bytes */
|
||||
u_int8_t _opt[60 - sizeof(struct tcphdr)], *op;
|
||||
@@ -57,7 +57,7 @@ tcp_find_option(u_int8_t option,
|
||||
op = skb_header_pointer(skb, protoff + sizeof(struct tcphdr),
|
||||
optlen, _opt);
|
||||
if (op == NULL) {
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -78,7 +78,7 @@ tcp_match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
struct tcphdr _tcph, *th;
|
||||
const struct xt_tcp *tcpinfo = matchinfo;
|
||||
@@ -92,7 +92,7 @@ tcp_match(const struct sk_buff *skb,
|
||||
*/
|
||||
if (offset == 1) {
|
||||
duprintf("Dropping evil TCP offset=1 frag.\n");
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
}
|
||||
/* Must not be a fragment. */
|
||||
return 0;
|
||||
@@ -105,7 +105,7 @@ tcp_match(const struct sk_buff *skb,
|
||||
/* We've been asked to examine this packet, and we
|
||||
can't. Hence, no choice but to drop. */
|
||||
duprintf("Dropping evil TCP offset=0 tinygram.\n");
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -123,7 +123,7 @@ tcp_match(const struct sk_buff *skb,
|
||||
return 0;
|
||||
if (tcpinfo->option) {
|
||||
if (th->doff * 4 < sizeof(_tcph)) {
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
if (!tcp_find_option(tcpinfo->option, skb, protoff,
|
||||
@@ -157,7 +157,7 @@ udp_match(const struct sk_buff *skb,
|
||||
const void *matchinfo,
|
||||
int offset,
|
||||
unsigned int protoff,
|
||||
int *hotdrop)
|
||||
bool *hotdrop)
|
||||
{
|
||||
struct udphdr _udph, *uh;
|
||||
const struct xt_udp *udpinfo = matchinfo;
|
||||
@@ -171,7 +171,7 @@ udp_match(const struct sk_buff *skb,
|
||||
/* We've been asked to examine this packet, and we
|
||||
can't. Hence, no choice but to drop. */
|
||||
duprintf("Dropping evil UDP tinygram.\n");
|
||||
*hotdrop = 1;
|
||||
*hotdrop = true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user