lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

smsc95xx: signedness bug in get_regs()

Browse Source 
"retval" has to be a signed integer for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter
2012-07-10 20:32:51 +00:00
committed by David S. Miller
parent 064bff1c9f
commit d348446b88
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/usb/smsc95xx.c
View File

@ -589,7 +589,8 @@ smsc95xx_ethtool_getregs(struct net_device *netdev, struct ethtool_regs *regs,
void *buf) void *buf)
{ {
struct usbnet *dev = netdev_priv(netdev); struct usbnet *dev = netdev_priv(netdev);
unsigned int i, j, retval; unsigned int i, j;
int retval;
u32 *data = buf; u32 *data = buf;
retval = smsc95xx_read_reg(dev, ID_REV, &regs->version); retval = smsc95xx_read_reg(dev, ID_REV, &regs->version);