lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

V4L/DVB (9071): S2API: Implement result codes for individual commands

Browse Source 
This allows application developers to determine which particular
command in a sequence is invalid, or failing with error.

Signed-off-by: Steven Toth <stoth@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Steven Toth
2008-09-26 00:16:25 -03:00
committed by Mauro Carvalho Chehab
parent 459702bf98
commit d48cb402a1
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/media/dvb/dvb-core/dvb_frontend.c
View File

@@ -1262,8 +1262,10 @@ static int dvb_frontend_ioctl_properties(struct inode *inode, struct file *file,
goto out; goto out;
} }
for (i = 0; i < tvps->num; i++) for (i = 0; i < tvps->num; i++) {
err |= dtv_property_process_set(fe, tvp + i, inode, file); (tvp + i)->result = dtv_property_process_set(fe, tvp + i, inode, file);
err |= (tvp + i)->result;
}
if(fe->dtv_property_cache.state == DTV_TUNE) { if(fe->dtv_property_cache.state == DTV_TUNE) {
printk("%s() Property cache is full, tuning\n", __FUNCTION__); printk("%s() Property cache is full, tuning\n", __FUNCTION__);
@@ -1295,8 +1297,10 @@ static int dvb_frontend_ioctl_properties(struct inode *inode, struct file *file,
goto out; goto out;
} }
for (i = 0; i < tvps->num; i++) for (i = 0; i < tvps->num; i++) {
err |= dtv_property_process_get(fe, tvp + i, inode, file); (tvp + i)->result = dtv_property_process_get(fe, tvp + i, inode, file);
err |= (tvp + i)->result;
}
if (copy_to_user(tvps->props, tvp, tvps->num * sizeof(struct dtv_property))) { if (copy_to_user(tvps->props, tvp, tvps->num * sizeof(struct dtv_property))) {
err = -EFAULT; err = -EFAULT;

1
include/linux/dvb/frontend.h
View File

@@ -323,6 +323,7 @@ struct dtv_property {
void *reserved2; void *reserved2;
} buffer; } buffer;
} u; } u;
int result;
} __attribute__ ((packed)); } __attribute__ ((packed));
/* No more than 16 properties during any given ioctl */ /* No more than 16 properties during any given ioctl */