[XFS] Clean up some existing compat ioctl calls
Create a new xfs_ioctl.h file which has prototypes for ioctl helpers that may be called in compat mode. Change several compat ioctl cases which are IOW to simply copy in the userspace argument, then call the common ioctl helper. This also fixes xfs_compat_ioc_fsgeometry_v1(), which had it backwards before; it copied in an (empty) arg, then copied out the native result, which probably corrupted userspace. It should be translating on the copyout. Also, a bit of formatting cleanup for consistency, and conversion of all error returns to use XFS_ERROR(). Signed-off-by: Eric Sandeen <sandeen@sandeen.net> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
This commit is contained in:
committed by
Lachlan McIlroy
parent
ffae263a64
commit
d5547f9fee
@ -68,7 +68,7 @@
|
||||
* XFS_IOC_PATH_TO_HANDLE
|
||||
* returns full handle for a path
|
||||
*/
|
||||
STATIC int
|
||||
int
|
||||
xfs_find_handle(
|
||||
unsigned int cmd,
|
||||
xfs_fsop_handlereq_t *hreq)
|
||||
@ -245,7 +245,7 @@ xfs_vget_fsop_handlereq(
|
||||
return 0;
|
||||
}
|
||||
|
||||
STATIC int
|
||||
int
|
||||
xfs_open_by_handle(
|
||||
xfs_mount_t *mp,
|
||||
xfs_fsop_handlereq_t *hreq,
|
||||
@ -355,7 +355,7 @@ do_readlink(
|
||||
}
|
||||
|
||||
|
||||
STATIC int
|
||||
int
|
||||
xfs_readlink_by_handle(
|
||||
xfs_mount_t *mp,
|
||||
xfs_fsop_handlereq_t *hreq,
|
||||
@ -651,7 +651,7 @@ xfs_attrmulti_by_handle(
|
||||
return -error;
|
||||
}
|
||||
|
||||
STATIC int
|
||||
int
|
||||
xfs_ioc_space(
|
||||
struct xfs_inode *ip,
|
||||
struct inode *inode,
|
||||
|
Reference in New Issue
Block a user