lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[TIPC] net/tipc/port.c: fix NULL dereference

Browse Source 
The correct order is: NULL check before dereference

Spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Adrian Bunk
2006-10-31 16:59:35 -08:00
committed by David S. Miller
parent 3ccfc65c50
commit d55b4c631e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
net/tipc/port.c
View File

@@ -1136,11 +1136,12 @@ int tipc_publish(u32 ref, unsigned int scope, struct tipc_name_seq const *seq)
int res = -EINVAL; int res = -EINVAL;
p_ptr = tipc_port_lock(ref); p_ptr = tipc_port_lock(ref);
if (!p_ptr)
return -EINVAL;
dbg("tipc_publ %u, p_ptr = %x, conn = %x, scope = %x, " dbg("tipc_publ %u, p_ptr = %x, conn = %x, scope = %x, "
"lower = %u, upper = %u\n", "lower = %u, upper = %u\n",
ref, p_ptr, p_ptr->publ.connected, scope, seq->lower, seq->upper); ref, p_ptr, p_ptr->publ.connected, scope, seq->lower, seq->upper);
if (!p_ptr)
return -EINVAL;
if (p_ptr->publ.connected) if (p_ptr->publ.connected)
goto exit; goto exit;
if (seq->lower > seq->upper) if (seq->lower > seq->upper)