lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

KVM: fix assigned_device_enable_host_msix error handling

Browse Source 
Free IRQ's and disable MSIX upon failure.

Cc: Avi Kivity <avi@redhat.com>
Signed-off-by: Jing Zhang <zj.barak@gmail.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
This commit is contained in:
jing zhang
2010-03-13 15:00:45 +08:00
committed by Avi Kivity
parent a87fa35514
commit d57e2c0740
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
virt/kvm/assigned-dev.c
View File

@@ -316,12 +316,16 @@ static int assigned_device_enable_host_msix(struct kvm *kvm,
kvm_assigned_dev_intr, 0, kvm_assigned_dev_intr, 0,
"kvm_assigned_msix_device", "kvm_assigned_msix_device",
(void *)dev); (void *)dev);
/* FIXME: free requested_irq's on failure */
if (r) if (r)
return r; goto err;
} }
return 0; return 0;
err:
for (i -= 1; i >= 0; i--)
free_irq(dev->host_msix_entries[i].vector, (void *)dev);
pci_disable_msix(dev->dev);
return r;
} }
#endif #endif