lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

m32r: remove redundant tests on unsigned

Browse Source 
`off' and `max_cpus' are unsigned.  When negative they are wrapped and
caught by the other test.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Hirokazu Takata <takata@linux-m32r.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Roel Kluin
2009-09-21 17:04:03 -07:00
committed by Linus Torvalds
parent 1f69366545
commit d5a6d17395
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
arch/m32r/kernel/ptrace.c
View File

@@ -77,7 +77,7 @@ static int ptrace_read_user(struct task_struct *tsk, unsigned long off,
struct user * dummy = NULL; struct user * dummy = NULL;
#endif #endif
if ((off & 3) || (off < 0) || (off > sizeof(struct user) - 3)) if ((off & 3) || off > sizeof(struct user) - 3)
return -EIO; return -EIO;
off >>= 2; off >>= 2;
@@ -139,8 +139,7 @@ static int ptrace_write_user(struct task_struct *tsk, unsigned long off,
struct user * dummy = NULL; struct user * dummy = NULL;
#endif #endif
if ((off & 3) || off < 0 || if ((off & 3) || off > sizeof(struct user) - 3)
off > sizeof(struct user) - 3)
return -EIO; return -EIO;
off >>= 2; off >>= 2;

2
arch/m32r/kernel/smpboot.c
View File

@@ -213,7 +213,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
if (!physid_isset(phys_id, phys_cpu_present_map)) if (!physid_isset(phys_id, phys_cpu_present_map))
continue; continue;
if ((max_cpus >= 0) && (max_cpus <= cpucount + 1)) if (max_cpus <= cpucount + 1)
continue; continue;
do_boot_cpu(phys_id); do_boot_cpu(phys_id);