lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

perf annotate: Allocate history size correctly

Browse Source 
Symbol offset history table size does not get updated properly
when it is being resized. This leads to garbage results in
perf annotate.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Nick Piggin
2009-11-17 12:29:38 +01:00
committed by Ingo Molnar
parent c10edee2e1
commit d62d77fd18
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/perf/util/symbol.c
View File

@@ -227,6 +227,10 @@ static int dso__load_kallsyms(struct dso *self, symbol_filter_t filter, int v)
*curr = rb_entry(nd, struct symbol, rb_node); *curr = rb_entry(nd, struct symbol, rb_node);
prev->end = curr->start - 1; prev->end = curr->start - 1;
if (prev->hist) {
free(prev->hist);
prev->hist = calloc(sizeof(u64), prev->end - prev->start);
}
prevnd = nd; prevnd = nd;
} }
@@ -883,6 +887,10 @@ static inline void dso__fill_symbol_holes(struct dso *self)
pos->end = prev->end; pos->end = prev->end;
else if (hole) else if (hole)
pos->end = prev->start - 1; pos->end = prev->start - 1;
if (pos->hist) {
free(pos->hist);
pos->hist = calloc(sizeof(u64), pos->end - pos->start);
}
} }
} }
prev = pos; prev = pos;