lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[IPV6]: Make fib6_init to return an error code.

Browse Source 
If there is an error in the initialization function, nothing is
followed up to the caller. So I add a return value to be set for the
init function.

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
Acked-by: Benjamin Thery <benjamin.thery@bull.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Daniel Lezcano
2007-12-07 00:40:34 -08:00
committed by David S. Miller
parent 5a3e55d68e
commit d63bddbe90
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/net/ip6_fib.h
View File

@@ -224,7 +224,7 @@ extern void fib6_run_gc(unsigned long dummy);
extern void fib6_gc_cleanup(void); extern void fib6_gc_cleanup(void);
extern void fib6_init(void); extern int fib6_init(void);
extern void fib6_rules_init(void); extern void fib6_rules_init(void);
extern void fib6_rules_cleanup(void); extern void fib6_rules_cleanup(void);

14
net/ipv6/ip6_fib.c
View File

@@ -1473,16 +1473,24 @@ void fib6_run_gc(unsigned long dummy)
spin_unlock_bh(&fib6_gc_lock); spin_unlock_bh(&fib6_gc_lock);
} }
void __init fib6_init(void) int __init fib6_init(void)
{ {
int ret;
fib6_node_kmem = kmem_cache_create("fib6_nodes", fib6_node_kmem = kmem_cache_create("fib6_nodes",
sizeof(struct fib6_node), sizeof(struct fib6_node),
0, SLAB_HWCACHE_ALIGN|SLAB_PANIC, 0, SLAB_HWCACHE_ALIGN|SLAB_PANIC,
NULL); NULL);
fib6_tables_init(); fib6_tables_init();
__rtnl_register(PF_INET6, RTM_GETROUTE, NULL, inet6_dump_fib); ret = __rtnl_register(PF_INET6, RTM_GETROUTE, NULL, inet6_dump_fib);
if (ret)
goto out_kmem_cache_create;
out:
return ret;
out_kmem_cache_create:
kmem_cache_destroy(fib6_node_kmem);
goto out;
} }
void fib6_gc_cleanup(void) void fib6_gc_cleanup(void)