lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

latencytop: fix memory leak on latency proc file

Browse Source 
At lstats_open(), calling get_proc_task() gets task struct, but it never put.
put_task_struct() should be called when releasing.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Hiroshi Shimamoto
2008-02-14 10:27:00 -08:00
committed by Ingo Molnar
parent ae0027869d
commit d6643d12cb
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
fs/proc/base.c
View File

@@ -360,6 +360,15 @@ static int lstats_open(struct inode *inode, struct file *file)
return ret; return ret;
} }
static int lstats_release(struct inode *inode, struct file *file)
{
struct seq_file *m = file->private_data;
struct task_struct *task = m->private;
put_task_struct(task);
return single_release(inode, file);
}
static ssize_t lstats_write(struct file *file, const char __user *buf, static ssize_t lstats_write(struct file *file, const char __user *buf,
size_t count, loff_t *offs) size_t count, loff_t *offs)
{ {
@@ -378,7 +387,7 @@ static const struct file_operations proc_lstats_operations = {
.read = seq_read, .read = seq_read,
.write = lstats_write, .write = lstats_write,
.llseek = seq_lseek, .llseek = seq_lseek,
.release = single_release, .release = lstats_release,
}; };
#endif #endif