lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Input: wm97xx-core - only schedule interrupt handler if not already scheduled

Browse Source 
As well as clarifying the fact that the driver can cope if a second
interrupt occurs before the IRQ work is scheduled this also ensures
that calls to the machine irq_enable() are balanced, making that easier
to implement.  Normally this is redundant due to the interrupt disabling
but some unusal board configurations can trigger it.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Mark Brown
2008-04-17 09:24:39 -04:00
committed by Dmitry Torokhov
parent 4db8a5f21e
commit d808fbe5b4
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/input/touchscreen/wm97xx-core.c
View File

@@ -328,18 +328,18 @@ static void wm97xx_pen_irq_worker(struct work_struct *work)
* *
* We have to disable the codec interrupt in the handler because it * We have to disable the codec interrupt in the handler because it
* can take upto 1ms to clear the interrupt source. We schedule a task * can take upto 1ms to clear the interrupt source. We schedule a task
* in a work queue to do the actual interaction with the chip (it * in a work queue to do the actual interaction with the chip. The
* doesn't matter if we end up reenqueing it before it is executed * interrupt is then enabled again in the slow handler when the source
* since we don't touch the chip until it has run). The interrupt is * has been cleared.
* then enabled again in the slow handler when the source has been
* cleared.
*/ */
static irqreturn_t wm97xx_pen_interrupt(int irq, void *dev_id) static irqreturn_t wm97xx_pen_interrupt(int irq, void *dev_id)
{ {
struct wm97xx *wm = dev_id; struct wm97xx *wm = dev_id;
if (!work_pending(&wm->pen_event_work)) {
wm->mach_ops->irq_enable(wm, 0); wm->mach_ops->irq_enable(wm, 0);
queue_work(wm->ts_workq, &wm->pen_event_work); queue_work(wm->ts_workq, &wm->pen_event_work);
}
return IRQ_HANDLED; return IRQ_HANDLED;
} }