lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SCSI] mpt2sas: Fix linux driver sparse errors

Browse Source 
Fix several endian issues found by runing sparse.

Signed-off-by: Nagalakshmi Nandigama <nagalakshmi.nandigama@lsi.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
nagalakshmi.nandigama@lsi.com
2012-03-20 12:07:48 +05:30
committed by James Bottomley
parent 298c794def
commit d838c36cb7
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/scsi/mpt2sas/mpt2sas_base.c
View File

@@ -4160,7 +4160,8 @@ _base_make_ioc_operational(struct MPT2SAS_ADAPTER *ioc, int sleep_flag)
if (ioc->is_driver_loading) { if (ioc->is_driver_loading) {
if (ioc->is_warpdrive && ioc->manu_pg10.OEMIdentifier if (ioc->is_warpdrive && ioc->manu_pg10.OEMIdentifier
== 0x80) { == 0x80) {
hide_flag = (u8) (ioc->manu_pg10.OEMSpecificFlags0 & hide_flag = (u8) (
le32_to_cpu(ioc->manu_pg10.OEMSpecificFlags0) &
MFG_PAGE10_HIDE_SSDS_MASK); MFG_PAGE10_HIDE_SSDS_MASK);
if (hide_flag != MFG_PAGE10_HIDE_SSDS_MASK) if (hide_flag != MFG_PAGE10_HIDE_SSDS_MASK)
ioc->mfg_pg10_hide_flag = hide_flag; ioc->mfg_pg10_hide_flag = hide_flag;

7
drivers/scsi/mpt2sas/mpt2sas_scsih.c
View File

@@ -1854,7 +1854,8 @@ _scsih_init_warpdrive_properties(struct MPT2SAS_ADAPTER *ioc,
if (mpt2sas_config_get_phys_disk_pg0(ioc, &mpi_reply, if (mpt2sas_config_get_phys_disk_pg0(ioc, &mpi_reply,
&pd_pg0, MPI2_PHYSDISK_PGAD_FORM_PHYSDISKNUM, &pd_pg0, MPI2_PHYSDISK_PGAD_FORM_PHYSDISKNUM,
vol_pg0->PhysDisk[count].PhysDiskNum) || vol_pg0->PhysDisk[count].PhysDiskNum) ||
pd_pg0.DevHandle == MPT2SAS_INVALID_DEVICE_HANDLE) { le16_to_cpu(pd_pg0.DevHandle) ==
MPT2SAS_INVALID_DEVICE_HANDLE) {
printk(MPT2SAS_INFO_FMT "WarpDrive : Direct IO is " printk(MPT2SAS_INFO_FMT "WarpDrive : Direct IO is "
"disabled for the drive with handle(0x%04x) member" "disabled for the drive with handle(0x%04x) member"
"handle retrieval failed for member number=%d\n", "handle retrieval failed for member number=%d\n",
@@ -7411,14 +7412,14 @@ mpt2sas_scsih_event_callback(struct MPT2SAS_ADAPTER *ioc, u8 msix_index,
case MPI2_EVENT_LOG_ENTRY_ADDED: case MPI2_EVENT_LOG_ENTRY_ADDED:
{ {
Mpi2EventDataLogEntryAdded_t *log_entry; Mpi2EventDataLogEntryAdded_t *log_entry;
u32 *log_code; __le32 *log_code;
if (!ioc->is_warpdrive) if (!ioc->is_warpdrive)
break; break;
log_entry = (Mpi2EventDataLogEntryAdded_t *) log_entry = (Mpi2EventDataLogEntryAdded_t *)
mpi_reply->EventData; mpi_reply->EventData;
log_code = (u32 *)log_entry->LogData; log_code = (__le32 *)log_entry->LogData;
if (le16_to_cpu(log_entry->LogEntryQualifier) if (le16_to_cpu(log_entry->LogEntryQualifier)
!= MPT2_WARPDRIVE_LOGENTRY) != MPT2_WARPDRIVE_LOGENTRY)