lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ieee1394: video1394: Use memdup_user

Browse Source 
...when user data is immediately copied into the allocated region.

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (changelog)
This commit is contained in:
Julia Lawall
2010-05-22 10:22:00 +02:00
committed by Stefan Richter
parent 3014420b6b
commit d8c1fa4af0
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/ieee1394/video1394.c
View File

@@ -1045,14 +1045,9 @@ static long video1394_ioctl(struct file *file,
if (get_user(qv, &p->packet_sizes)) if (get_user(qv, &p->packet_sizes))
return -EFAULT; return -EFAULT;
psizes = kmalloc(buf_size, GFP_KERNEL); psizes = memdup_user(qv, buf_size);
if (!psizes) if (IS_ERR(psizes))
return -ENOMEM; return PTR_ERR(psizes);
if (copy_from_user(psizes, qv, buf_size)) {
kfree(psizes);
return -EFAULT;
}
} }
spin_lock_irqsave(&d->lock,flags); spin_lock_irqsave(&d->lock,flags);