lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bonding: initialize before registration

Browse Source 
Avoid a unnecessary carrier state transistion that happens when device
is registered.
Lockdep works better if initialization is done before registration as well.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Stephen Hemminger
2009-06-12 19:02:45 +00:00
committed by David S. Miller
parent d2991f7535
commit d93216051a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/bonding/bond_main.c
View File

@@ -5164,15 +5164,15 @@ int bond_create(const char *name)
goto out_netdev; goto out_netdev;
} }
bond_set_lockdep_class(bond_dev);
netif_carrier_off(bond_dev);
res = register_netdevice(bond_dev); res = register_netdevice(bond_dev);
if (res < 0) { if (res < 0) {
goto out_bond; goto out_bond;
} }
bond_set_lockdep_class(bond_dev);
netif_carrier_off(bond_dev);
up_write(&bonding_rwsem); up_write(&bonding_rwsem);
rtnl_unlock(); /* allows sysfs registration of net device */ rtnl_unlock(); /* allows sysfs registration of net device */
res = bond_create_sysfs_entry(netdev_priv(bond_dev)); res = bond_create_sysfs_entry(netdev_priv(bond_dev));