lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[ALSA] rtctimer: optimize module parameter validation

Browse Source 
Modules: RTC timer driver

The check whether rtctimer_freq is a power of two can be done easier
with a simple bit operation.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
This commit is contained in:
Clemens Ladisch
2005-09-27 15:57:24 +02:00
committed by Jaroslav Kysela
parent adf25df1be
commit d9ad1bdd6d
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
sound/core/rtctimer.c
View File

@@ -119,16 +119,11 @@ static void rtctimer_interrupt(void *private_data)
*/ */
static int __init rtctimer_init(void) static int __init rtctimer_init(void)
{ {
int order, err; int err;
snd_timer_t *timer; snd_timer_t *timer;
if (rtctimer_freq < 2 || rtctimer_freq > 8192) { if (rtctimer_freq < 2 || rtctimer_freq > 8192 ||
snd_printk(KERN_ERR "rtctimer: invalid frequency %d\n", rtctimer_freq); (rtctimer_freq & (rtctimer_freq - 1)) != 0) {
return -EINVAL;
}
for (order = 1; rtctimer_freq > order; order <<= 1)
;
if (rtctimer_freq != order) {
snd_printk(KERN_ERR "rtctimer: invalid frequency %d\n", rtctimer_freq); snd_printk(KERN_ERR "rtctimer: invalid frequency %d\n", rtctimer_freq);
return -EINVAL; return -EINVAL;
} }