lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

use is_power_of_2() in cxgb3/cxgb3_main.c

Browse Source 
Replace (n & (n-1)) with is_power_of_2()

Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
vignesh babu
2007-07-09 11:50:22 -07:00
committed by Jeff Garzik
parent de0d3dc0e8
commit d9da466a3c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/cxgb3/cxgb3_main.c
View File

@@ -43,6 +43,7 @@
#include <linux/proc_fs.h> #include <linux/proc_fs.h>
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/firmware.h> #include <linux/firmware.h>
#include <linux/log2.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include "common.h" #include "common.h"
@@ -1818,8 +1819,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
return -EBUSY; return -EBUSY;
if (copy_from_user(&m, useraddr, sizeof(m))) if (copy_from_user(&m, useraddr, sizeof(m)))
return -EFAULT; return -EFAULT;
if (!m.rx_pg_sz || (m.rx_pg_sz & (m.rx_pg_sz - 1)) || if (!is_power_of_2(m.rx_pg_sz) ||
!m.tx_pg_sz || (m.tx_pg_sz & (m.tx_pg_sz - 1))) !is_power_of_2(m.tx_pg_sz))
return -EINVAL; /* not power of 2 */ return -EINVAL; /* not power of 2 */
if (!(m.rx_pg_sz & 0x14000)) if (!(m.rx_pg_sz & 0x14000))
return -EINVAL; /* not 16KB or 64KB */ return -EINVAL; /* not 16KB or 64KB */