lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[ARM] pxafb: fix building issue of incorrect reference

Browse Source 
Commit "d2a34c1 drivers/video: Move dereference after NULL test" introduced
a build error of "fbi->dev->platform_data->smart_update" being unknown type
to the compiler, fix this by removing the unnecessary test of 'fbi'.

Cc: Julia Lawall <julia@diku.dk>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
This commit is contained in:
Eric Miao
2009-12-26 16:25:18 +08:00
parent 6b7b284958
commit da2c3f0ead
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/video/pxafb.c
View File

@@ -1221,9 +1221,9 @@ static void setup_smart_timing(struct pxafb_info *fbi,
static int pxafb_smart_thread(void *arg) static int pxafb_smart_thread(void *arg)
{ {
struct pxafb_info *fbi = arg; struct pxafb_info *fbi = arg;
struct pxafb_mach_info *inf; struct pxafb_mach_info *inf = fbi->dev->platform_data;
if (!fbi || !fbi->dev->platform_data->smart_update) { if (!inf->smart_update) {
pr_err("%s: not properly initialized, thread terminated\n", pr_err("%s: not properly initialized, thread terminated\n",
__func__); __func__);
return -EINVAL; return -EINVAL;