lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

xfs: use xfs_ilock_data_map_shared in xfs_qm_dqiterate

Browse Source 
We might not have read in the extent list at this point, so make sure we
take the ilock exclusively if we have to do so.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
This commit is contained in:
Christoph Hellwig
2013-12-06 12:30:14 -08:00
committed by Ben Myers
parent f4df8adc83
commit da51d32d45
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/xfs/xfs_qm.c
View File

@@ -1222,16 +1222,18 @@ xfs_qm_dqiterate(
lblkno = 0; lblkno = 0;
maxlblkcnt = XFS_B_TO_FSB(mp, mp->m_super->s_maxbytes); maxlblkcnt = XFS_B_TO_FSB(mp, mp->m_super->s_maxbytes);
do { do {
uint lock_mode;
nmaps = XFS_DQITER_MAP_SIZE; nmaps = XFS_DQITER_MAP_SIZE;
/* /*
* We aren't changing the inode itself. Just changing * We aren't changing the inode itself. Just changing
* some of its data. No new blocks are added here, and * some of its data. No new blocks are added here, and
* the inode is never added to the transaction. * the inode is never added to the transaction.
*/ */
xfs_ilock(qip, XFS_ILOCK_SHARED); lock_mode = xfs_ilock_data_map_shared(qip);
error = xfs_bmapi_read(qip, lblkno, maxlblkcnt - lblkno, error = xfs_bmapi_read(qip, lblkno, maxlblkcnt - lblkno,
map, &nmaps, 0); map, &nmaps, 0);
xfs_iunlock(qip, XFS_ILOCK_SHARED); xfs_iunlock(qip, lock_mode);
if (error) if (error)
break; break;