lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[NET]: use hlist_unhashed()

Browse Source 
Use hlist_unhashed() rather than accessing inside data structure.

Signed-off-by: Akinobu Mita <mita@miraclelinux.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Akinobu Mita
2006-04-28 15:21:23 -07:00
committed by David S. Miller
parent a536e07787
commit da753beaeb
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/linux/list.h
View File

@@ -619,7 +619,7 @@ static inline void hlist_del_rcu(struct hlist_node *n)
static inline void hlist_del_init(struct hlist_node *n) static inline void hlist_del_init(struct hlist_node *n)
{ {
if (n->pprev) { if (!hlist_unhashed(n)) {
__hlist_del(n); __hlist_del(n);
INIT_HLIST_NODE(n); INIT_HLIST_NODE(n);
} }

2
include/net/inet_timewait_sock.h
View File

@@ -150,7 +150,7 @@ static inline void inet_twsk_add_bind_node(struct inet_timewait_sock *tw,
static inline int inet_twsk_dead_hashed(const struct inet_timewait_sock *tw) static inline int inet_twsk_dead_hashed(const struct inet_timewait_sock *tw)
{ {
return tw->tw_death_node.pprev != NULL; return !hlist_unhashed(&tw->tw_death_node);
} }
static inline void inet_twsk_dead_node_init(struct inet_timewait_sock *tw) static inline void inet_twsk_dead_node_init(struct inet_timewait_sock *tw)

2
include/net/sock.h
View File

@@ -279,7 +279,7 @@ static inline int sk_unhashed(const struct sock *sk)
static inline int sk_hashed(const struct sock *sk) static inline int sk_hashed(const struct sock *sk)
{ {
return sk->sk_node.pprev != NULL; return !sk_unhashed(sk);
} }
static __inline__ void sk_node_init(struct hlist_node *node) static __inline__ void sk_node_init(struct hlist_node *node)