lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tracing: Fix check of ftrace_trace_arrays list_empty() check

Browse Source 
The check that tests if ftrace_trace_arrays is empty in
top_trace_array(), uses the .prev pointer:

  if (list_empty(ftrace_trace_arrays.prev))

instead of testing the variable itself:

  if (list_empty(&ftrace_trace_arrays))

Although it is technically correct, it is awkward and confusing.
Use the proper method.

Link: http://lkml.kernel.org/r/87oay1bas8.fsf@sejong.aot.lge.com

Reported-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
Steven Rostedt (Red Hat)
2014-06-10 13:53:50 -04:00
committed by Steven Rostedt
parent f0b70cc48c
commit da9c3413a2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/trace/trace.h
View File

@@ -252,7 +252,7 @@ static inline struct trace_array *top_trace_array(void)
{ {
struct trace_array *tr; struct trace_array *tr;
if (list_empty(ftrace_trace_arrays.prev)) if (list_empty(&ftrace_trace_arrays))
return NULL; return NULL;
tr = list_entry(ftrace_trace_arrays.prev, tr = list_entry(ftrace_trace_arrays.prev,