lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Staging: sep: load_rom is remarkably verbose and repetetive

Browse Source 
Give it a haircut

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Alan Cox
2009-08-07 19:24:58 +01:00
committed by Greg Kroah-Hartman
parent 3cacf72922
commit dabe6e6946
1 changed files with 10 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
drivers/staging/sep/sep_driver.c
View File

@@ -105,9 +105,9 @@ static void sep_load_rom_code(struct sep_device *sep)
sep_write_reg(sep, HW_HOST_SEP_SW_RST_REG_ADDR, 0x1); sep_write_reg(sep, HW_HOST_SEP_SW_RST_REG_ADDR, 0x1);
/* poll for SEP ROM boot finish */ /* poll for SEP ROM boot finish */
do { do
reg = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR3_REG_ADDR); reg = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR3_REG_ADDR);
} while (!reg); while (!reg);
edbg("SEP Driver: ROM polling ended\n"); edbg("SEP Driver: ROM polling ended\n");
@@ -117,31 +117,18 @@ static void sep_load_rom_code(struct sep_device *sep)
error = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR0_REG_ADDR); error = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR0_REG_ADDR);
edbg("SEP Driver: ROM polling case 1\n"); edbg("SEP Driver: ROM polling case 1\n");
break; break;
case 0x4:
/* Cold boot ended successfully */
case 0x8:
/* Warmboot ended successfully */
case 0x10:
/* ColdWarm boot ended successfully */
error = 0;
case 0x2: case 0x2:
/* Boot First Phase ended */ /* Boot First Phase ended */
warning = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR0_REG_ADDR); warning = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR0_REG_ADDR);
edbg("SEP Driver: ROM polling case 2\n");
break;
case 0x4:
/* Cold boot ended successfully */
warning = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR0_REG_ADDR);
edbg("SEP Driver: ROM polling case 4\n");
error = 0;
break;
case 0x8:
/* Warmboot ended successfully */
warning = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR0_REG_ADDR);
edbg("SEP Driver: ROM polling case 8\n");
error = 0;
break;
case 0x10:
/* ColdWarm boot ended successfully */
warning = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR0_REG_ADDR);
edbg("SEP Driver: ROM polling case 16\n");
error = 0;
break;
case 0x20: case 0x20:
edbg("SEP Driver: ROM polling case 32\n"); edbg("SEP Driver: ROM polling case %d\n", reg);
break; break;
} }