lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] i386: fix uses of user_mode() vs. user_mode_vm()

Browse Source 
>commit 76381fee7e
>Author: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
>Date:   Thu Jun 23 00:08:46 2005 -0700
>
>    [PATCH] xen: x86_64: use more usermode macro
>
>    Make use of the user_mode macro where it's possible.  This is useful for Xen
>    because it will need only to redefine only the macro to a hypervisor call.

I am of the opinion that the above changeset is incomplete, i.e.  it missed
converting some previous uses of user_mode to user_mode_vm.  While most of
them could be considered just cosmetical, at least the one in die_nmi
doesn't appear to be.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
Cc: Zachary Amsden <zach@vmware.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Jan Beulich
2006-03-23 02:59:46 -08:00
committed by Linus Torvalds
parent 101f12af16
commit db753bdfc2
6 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
arch/i386/kernel/crash.c
View File

@@ -105,7 +105,7 @@ static int crash_nmi_callback(struct pt_regs *regs, int cpu)
return 1; return 1;
local_irq_disable(); local_irq_disable();
if (!user_mode(regs)) { if (!user_mode_vm(regs)) {
crash_fixup_ss_esp(&fixed_regs, regs); crash_fixup_ss_esp(&fixed_regs, regs);
regs = &fixed_regs; regs = &fixed_regs;
} }

2
arch/i386/kernel/process.c
View File

@@ -295,7 +295,7 @@ void show_regs(struct pt_regs * regs)
printk("EIP: %04x:[<%08lx>] CPU: %d\n",0xffff & regs->xcs,regs->eip, smp_processor_id()); printk("EIP: %04x:[<%08lx>] CPU: %d\n",0xffff & regs->xcs,regs->eip, smp_processor_id());
print_symbol("EIP is at %s\n", regs->eip); print_symbol("EIP is at %s\n", regs->eip);
if (user_mode(regs)) if (user_mode_vm(regs))
printk(" ESP: %04x:%08lx",0xffff & regs->xss,regs->esp); printk(" ESP: %04x:%08lx",0xffff & regs->xss,regs->esp);
printk(" EFLAGS: %08lx %s (%s %.*s)\n", printk(" EFLAGS: %08lx %s (%s %.*s)\n",
regs->eflags, print_tainted(), system_utsname.release, regs->eflags, print_tainted(), system_utsname.release,

4
arch/i386/kernel/traps.c
View File

@@ -254,7 +254,7 @@ void show_registers(struct pt_regs *regs)
esp = (unsigned long) (&regs->esp); esp = (unsigned long) (&regs->esp);
savesegment(ss, ss); savesegment(ss, ss);
if (user_mode(regs)) { if (user_mode_vm(regs)) {
in_kernel = 0; in_kernel = 0;
esp = regs->esp; esp = regs->esp;
ss = regs->xss & 0xffff; ss = regs->xss & 0xffff;
@@ -644,7 +644,7 @@ void die_nmi (struct pt_regs *regs, const char *msg)
/* If we are in kernel we are probably nested up pretty bad /* If we are in kernel we are probably nested up pretty bad
* and might aswell get out now while we still can. * and might aswell get out now while we still can.
*/ */
if (!user_mode(regs)) { if (!user_mode_vm(regs)) {
current->thread.trap_no = 2; current->thread.trap_no = 2;
crash_kexec(regs); crash_kexec(regs);
} }

2
include/asm-i386/mach-default/do_timer.h
View File

@@ -18,7 +18,7 @@ static inline void do_timer_interrupt_hook(struct pt_regs *regs)
{ {
do_timer(regs); do_timer(regs);
#ifndef CONFIG_SMP #ifndef CONFIG_SMP
update_process_times(user_mode(regs)); update_process_times(user_mode_vm(regs));
#endif #endif
/* /*
* In the SMP case we use the local APIC timer interrupt to do the * In the SMP case we use the local APIC timer interrupt to do the

2
include/asm-i386/mach-visws/do_timer.h
View File

@@ -11,7 +11,7 @@ static inline void do_timer_interrupt_hook(struct pt_regs *regs)
do_timer(regs); do_timer(regs);
#ifndef CONFIG_SMP #ifndef CONFIG_SMP
update_process_times(user_mode(regs)); update_process_times(user_mode_vm(regs));
#endif #endif
/* /*
* In the SMP case we use the local APIC timer interrupt to do the * In the SMP case we use the local APIC timer interrupt to do the

2
include/asm-i386/mach-voyager/do_timer.h
View File

@@ -5,7 +5,7 @@ static inline void do_timer_interrupt_hook(struct pt_regs *regs)
{ {
do_timer(regs); do_timer(regs);
#ifndef CONFIG_SMP #ifndef CONFIG_SMP
update_process_times(user_mode(regs)); update_process_times(user_mode_vm(regs));
#endif #endif
voyager_timer_interrupt(regs); voyager_timer_interrupt(regs);