lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] proc_loginuid_write() uses simple_strtoul() on non-terminated array

Browse Source 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2006-05-18 08:28:02 -04:00
parent ac03221a4f
commit e018290929
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
fs/proc/base.c
View File

@@ -1019,8 +1019,8 @@ static ssize_t proc_loginuid_write(struct file * file, const char __user * buf,
if (current != task) if (current != task)
return -EPERM; return -EPERM;
if (count > PAGE_SIZE) if (count >= PAGE_SIZE)
count = PAGE_SIZE; count = PAGE_SIZE - 1;
if (*ppos != 0) { if (*ppos != 0) {
/* No partial writes. */ /* No partial writes. */
@@ -1033,6 +1033,7 @@ static ssize_t proc_loginuid_write(struct file * file, const char __user * buf,
if (copy_from_user(page, buf, count)) if (copy_from_user(page, buf, count))
goto out_free_page; goto out_free_page;
page[count] = '\0';
loginuid = simple_strtoul(page, &tmp, 10); loginuid = simple_strtoul(page, &tmp, 10);
if (tmp == page) { if (tmp == page) {
length = -EINVAL; length = -EINVAL;