lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PCI/MSI: Use irq_get_msi_desc() to simplify code

Browse Source 
Use irq_get_msi_desc() to get MSI IRQ related msi_desc directly instead of
searching the dev->msi_list.

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Yijing Wang
2014-07-08 10:09:19 +08:00
committed by Bjorn Helgaas
parent 0dae508aac
commit e11ece5a5e
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/pci/msi.c
View File

@@ -487,7 +487,6 @@ EXPORT_SYMBOL_GPL(pci_restore_msi_state);
static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr, static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct pci_dev *pdev = to_pci_dev(dev);
struct msi_desc *entry; struct msi_desc *entry;
unsigned long irq; unsigned long irq;
int retval; int retval;
@@ -496,12 +495,11 @@ static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
if (retval) if (retval)
return retval; return retval;
list_for_each_entry(entry, &pdev->msi_list, list) { entry = irq_get_msi_desc(irq);
if (entry->irq == irq) { if (entry)
return sprintf(buf, "%s\n", return sprintf(buf, "%s\n",
entry->msi_attrib.is_msix ? "msix" : "msi"); entry->msi_attrib.is_msix ? "msix" : "msi");
}
}
return -ENODEV; return -ENODEV;
} }