lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

TTY: msm_serial, remove unneeded console set

Browse Source 
It doesn't make sense to set console to uart_port in console->setup.
At that time the console is set by uart_add_one_port already.

The call chain looked like:
uart_add_one_port()
  uport->cons = drv->cons;   <= once
  uart_configure_port()
    register_console()
     console->setup()
       port->cons = co;      <= second time

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jiri Slaby
2011-07-14 14:35:11 +02:00
committed by Greg Kroah-Hartman
parent 1f33a51d97
commit e150c4ccbe
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/msm_serial.c
View File

@@ -804,8 +804,6 @@ static int __init msm_console_setup(struct console *co, char *options)
if (unlikely(!port->membase)) if (unlikely(!port->membase))
return -ENXIO; return -ENXIO;
port->cons = co;
msm_init_clock(port); msm_init_clock(port);
if (options) if (options)