lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bna: fix sparse warnings/errors

Browse Source 
This fixes a several sparse warnings.
  * the __iomem tag was being used incorrectly (needs to be a prefix)
  * several variables should have been static since local to one file
  * the firmware was not being forwared declared
    and was const one place and not the other

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
stephen hemminger
2012-01-04 13:02:24 +00:00
committed by David S. Miller
parent 975419cf01
commit e1e0918fca
4 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/brocade/bna/bna_types.h
View File

@@ -427,7 +427,7 @@ struct bna_ethport {
/* Doorbell structure */ /* Doorbell structure */
struct bna_ib_dbell { struct bna_ib_dbell {
void *__iomem doorbell_addr; void __iomem *doorbell_addr;
u32 doorbell_ack; u32 doorbell_ack;
}; };
@@ -463,7 +463,7 @@ struct bna_tcb {
u32 consumer_index; u32 consumer_index;
volatile u32 *hw_consumer_index; volatile u32 *hw_consumer_index;
u32 q_depth; u32 q_depth;
void *__iomem q_dbell; void __iomem *q_dbell;
struct bna_ib_dbell *i_dbell; struct bna_ib_dbell *i_dbell;
int page_idx; int page_idx;
int page_count; int page_count;
@@ -599,7 +599,7 @@ struct bna_rcb {
u32 producer_index; u32 producer_index;
u32 consumer_index; u32 consumer_index;
u32 q_depth; u32 q_depth;
void *__iomem q_dbell; void __iomem *q_dbell;
int page_idx; int page_idx;
int page_count; int page_count;
/* Control path */ /* Control path */

6
drivers/net/ethernet/brocade/bna/bnad.c
View File

@@ -53,9 +53,9 @@ MODULE_PARM_DESC(bna_debugfs_enable, "Enables debugfs feature, default=1,"
* Global variables * Global variables
*/ */
u32 bnad_rxqs_per_cq = 2; u32 bnad_rxqs_per_cq = 2;
u32 bna_id; static u32 bna_id;
struct mutex bnad_list_mutex; static struct mutex bnad_list_mutex;
LIST_HEAD(bnad_list); static LIST_HEAD(bnad_list);
static const u8 bnad_bcast_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; static const u8 bnad_bcast_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
/* /*

2
drivers/net/ethernet/brocade/bna/bnad.h
View File

@@ -347,7 +347,7 @@ struct bnad_drvinfo {
/* /*
* EXTERN VARIABLES * EXTERN VARIABLES
*/ */
extern struct firmware *bfi_fw; extern const struct firmware *bfi_fw;
extern u32 bnad_rxqs_per_cq; extern u32 bnad_rxqs_per_cq;
/* /*

1
drivers/net/ethernet/brocade/bna/cna_fwimg.c
View File

@@ -16,6 +16,7 @@
* www.brocade.com * www.brocade.com
*/ */
#include <linux/firmware.h> #include <linux/firmware.h>
#include "bnad.h"
#include "bfi.h" #include "bfi.h"
#include "cna.h" #include "cna.h"