lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

s390/sclp_sdias: Add missing break and "fall through"

Browse Source 
If the last block of the HSA is read, EVSTATE_ALL_STORED is returned
by SCLP. Because of a missing break in the switch statement two trace
entries are written in this case: "all stored" and "part stored".

This patch adds the missing break and also adds a "fall through"
comment to improve the readability.

Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Reported-by: David A Gilbert <DavidAGilbert@uk.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Michael Holzheu
2012-07-31 11:01:30 +02:00
committed by Martin Schwidefsky
parent d050351381
commit e206d3da58
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/s390/char/sclp_sdias.c
View File

@@ -242,11 +242,13 @@ int sclp_sdias_copy(void *dest, int start_blk, int nr_blks)
switch (sdias_evbuf.event_status) { switch (sdias_evbuf.event_status) {
case EVSTATE_ALL_STORED: case EVSTATE_ALL_STORED:
TRACE("all stored\n"); TRACE("all stored\n");
break;
case EVSTATE_PART_STORED: case EVSTATE_PART_STORED:
TRACE("part stored: %i\n", sdias_evbuf.blk_cnt); TRACE("part stored: %i\n", sdias_evbuf.blk_cnt);
break; break;
case EVSTATE_NO_DATA: case EVSTATE_NO_DATA:
TRACE("no data\n"); TRACE("no data\n");
/* fall through */
default: default:
pr_err("Error from SCLP while copying hsa. " pr_err("Error from SCLP while copying hsa. "
"Event status = %x\n", "Event status = %x\n",