lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put

Browse Source 
It is possible for the timer handlers to run after the call to
ip_mc_down so use in_dev_put instead of __in_dev_put in the handler
function in order to do proper cleanup when the refcnt reaches 0.
Otherwise, the refcnt can reach zero without the in_device being
destroyed and we end up leaking a reference to the net_device and
see messages like the following,

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Tested on linux-3.4.43.

Signed-off-by: Salam Noureddine <noureddine@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Salam Noureddine
2013-09-29 13:39:42 -07:00
committed by David S. Miller
parent 437a3ae1d0
commit e2401654dd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
net/ipv4/igmp.c
View File

@@ -736,7 +736,7 @@ static void igmp_gq_timer_expire(unsigned long data)
in_dev->mr_gq_running = 0; in_dev->mr_gq_running = 0;
igmpv3_send_report(in_dev, NULL); igmpv3_send_report(in_dev, NULL);
__in_dev_put(in_dev); in_dev_put(in_dev);
} }
static void igmp_ifc_timer_expire(unsigned long data) static void igmp_ifc_timer_expire(unsigned long data)
@@ -749,7 +749,7 @@ static void igmp_ifc_timer_expire(unsigned long data)
igmp_ifc_start_timer(in_dev, igmp_ifc_start_timer(in_dev,
unsolicited_report_interval(in_dev)); unsolicited_report_interval(in_dev));
} }
__in_dev_put(in_dev); in_dev_put(in_dev);
} }
static void igmp_ifc_event(struct in_device *in_dev) static void igmp_ifc_event(struct in_device *in_dev)