lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

binder: use freezable blocking calls

Browse Source 
Avoid waking up every thread sleeping in a binder call during
suspend and resume by calling a freezable blocking call.  Previous
patches modified the freezer to avoid sending wakeups to threads
that are blocked in freezable blocking calls.

This call was selected to be converted to a freezable call because
it doesn't hold any locks or release any resources when interrupted
that might be needed by another freezing task or a kernel driver
during suspend, and is a common site where idle userspace tasks are
blocked.

Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Colin Cross <ccross@android.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Colin Cross
2013-05-06 23:50:15 +00:00
committed by Rafael J. Wysocki
parent dd5ec0f4e7
commit e2610b268b
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/android/binder.c
View File

@@ -20,6 +20,7 @@
#include <asm/cacheflush.h> #include <asm/cacheflush.h>
#include <linux/fdtable.h> #include <linux/fdtable.h>
#include <linux/file.h> #include <linux/file.h>
#include <linux/freezer.h>
#include <linux/fs.h> #include <linux/fs.h>
#include <linux/list.h> #include <linux/list.h>
#include <linux/miscdevice.h> #include <linux/miscdevice.h>
@@ -2140,13 +2141,13 @@ retry:
if (!binder_has_proc_work(proc, thread)) if (!binder_has_proc_work(proc, thread))
ret = -EAGAIN; ret = -EAGAIN;
} else } else
ret = wait_event_interruptible_exclusive(proc->wait, binder_has_proc_work(proc, thread)); ret = wait_event_freezable_exclusive(proc->wait, binder_has_proc_work(proc, thread));
} else { } else {
if (non_block) { if (non_block) {
if (!binder_has_thread_work(thread)) if (!binder_has_thread_work(thread))
ret = -EAGAIN; ret = -EAGAIN;
} else } else
ret = wait_event_interruptible(thread->wait, binder_has_thread_work(thread)); ret = wait_event_freezable(thread->wait, binder_has_thread_work(thread));
} }
binder_lock(__func__); binder_lock(__func__);