lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drm/i915/ringbuffer: Remove broken intel_fill_struct()

Browse Source 
... before someone tries to use it. The code both calls
intel_ring_begin/advance() and open-codes the bookkeeping performed by
those two functions.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
This commit is contained in:
Chris Wilson
2010-10-21 19:00:02 +01:00
parent c717966744
commit e36c1cd729
2 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/gpu/drm/i915/intel_ringbuffer.c
View File

@@ -733,21 +733,6 @@ void intel_ring_advance(struct drm_device *dev,
ring->set_tail(dev, ring, ring->tail); ring->set_tail(dev, ring, ring->tail);
} }
void intel_fill_struct(struct drm_device *dev,
struct intel_ring_buffer *ring,
void *data,
unsigned int len)
{
unsigned int *virt = ring->virtual_start + ring->tail;
BUG_ON((len&~(4-1)) != 0);
intel_ring_begin(dev, ring, len/4);
memcpy(virt, data, len);
ring->tail += len;
ring->tail &= ring->size - 1;
ring->space -= len;
intel_ring_advance(dev, ring);
}
static const struct intel_ring_buffer render_ring = { static const struct intel_ring_buffer render_ring = {
.name = "render ring", .name = "render ring",
.id = RING_RENDER, .id = RING_RENDER,

4
drivers/gpu/drm/i915/intel_ringbuffer.h
View File

@@ -116,10 +116,6 @@ static inline void intel_ring_emit(struct drm_device *dev,
ring->tail += 4; ring->tail += 4;
} }
void intel_fill_struct(struct drm_device *dev,
struct intel_ring_buffer *ring,
void *data,
unsigned int len);
void intel_ring_advance(struct drm_device *dev, void intel_ring_advance(struct drm_device *dev,
struct intel_ring_buffer *ring); struct intel_ring_buffer *ring);