lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hwmon: (lm75) Make the writing to sysfs more robust

Browse Source 
Currently we get the checkpatch warning
consider using strict_strtol in preference to simple_strtol.
Also we should not allow any partially numeric values.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
This commit is contained in:
Shubhrajyoti D
2010-10-28 20:31:44 +02:00
committed by Jean Delvare
parent c4f99a2b8f
commit e3cd9528af
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/hwmon/lm75.c
View File

@@ -103,7 +103,12 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *da,
struct i2c_client *client = to_i2c_client(dev); struct i2c_client *client = to_i2c_client(dev);
struct lm75_data *data = i2c_get_clientdata(client); struct lm75_data *data = i2c_get_clientdata(client);
int nr = attr->index; int nr = attr->index;
long temp = simple_strtol(buf, NULL, 10); long temp;
int error;
error = strict_strtol(buf, 10, &temp);
if (error)
return error;
mutex_lock(&data->update_lock); mutex_lock(&data->update_lock);
data->temp[nr] = LM75_TEMP_TO_REG(temp); data->temp[nr] = LM75_TEMP_TO_REG(temp);