lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Xen: properly bound buffer access when parsing cpu/*/availability

Browse Source 
At the same time reduce the local buffers to 16 bytes each.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
This commit is contained in:
Jan Beulich
2013-01-15 13:31:43 +00:00
committed by Konrad Rzeszutek Wilk
parent d0b4d64aad
commit e5c702d3b2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/xen/cpu_hotplug.c
View File

@@ -25,10 +25,10 @@ static void disable_hotplug_cpu(int cpu)
static int vcpu_online(unsigned int cpu) static int vcpu_online(unsigned int cpu)
{ {
int err; int err;
char dir[32], state[32]; char dir[16], state[16];
sprintf(dir, "cpu/%u", cpu); sprintf(dir, "cpu/%u", cpu);
err = xenbus_scanf(XBT_NIL, dir, "availability", "%s", state); err = xenbus_scanf(XBT_NIL, dir, "availability", "%15s", state);
if (err != 1) { if (err != 1) {
if (!xen_initial_domain()) if (!xen_initial_domain())
printk(KERN_ERR "XENBUS: Unable to read cpu state\n"); printk(KERN_ERR "XENBUS: Unable to read cpu state\n");