lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ALSA: hda - Fix unbalanced runtime PM refcount after S3/S4

Browse Source 
When a machine goes to S3/S4 after power-save is enabled, the runtime
PM refcount might be incorrectly decreased because the power-down
triggered soon after resume assumes that the controller was already
powered up, and issues the pm_notify down.

This patch fixes the incorrect pm_notify call simply by checking the
current value properly.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai
2013-10-24 01:20:24 +02:00
parent d7f8761b66
commit e6bbe66667
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sound/pci/hda/hda_codec.c
View File

@@ -4864,8 +4864,8 @@ static void hda_power_work(struct work_struct *work)
spin_unlock(&codec->power_lock); spin_unlock(&codec->power_lock);
state = hda_call_codec_suspend(codec, true); state = hda_call_codec_suspend(codec, true);
codec->pm_down_notified = 0; if (!codec->pm_down_notified &&
if (!bus->power_keep_link_on && (state & AC_PWRST_CLK_STOP_OK)) { !bus->power_keep_link_on && (state & AC_PWRST_CLK_STOP_OK)) {
codec->pm_down_notified = 1; codec->pm_down_notified = 1;
hda_call_pm_notify(bus, false); hda_call_pm_notify(bus, false);
} }