lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

arch/x86/kernel/pci-iommu_table.c: Convert sprintf_symbol to %pS

Browse Source 
Coalesce format as well.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
This commit is contained in:
Joe Perches
2010-11-05 16:12:35 -07:00
committed by Joerg Roedel
parent 693d92a1bb
commit e969687595
1 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
arch/x86/kernel/pci-iommu_table.c
View File

@@ -50,20 +50,14 @@ void __init check_iommu_entries(struct iommu_table_entry *start,
struct iommu_table_entry *finish) struct iommu_table_entry *finish)
{ {
struct iommu_table_entry *p, *q, *x; struct iommu_table_entry *p, *q, *x;
char sym_p[KSYM_SYMBOL_LEN];
char sym_q[KSYM_SYMBOL_LEN];
/* Simple cyclic dependency checker. */ /* Simple cyclic dependency checker. */
for (p = start; p < finish; p++) { for (p = start; p < finish; p++) {
q = find_dependents_of(start, finish, p); q = find_dependents_of(start, finish, p);
x = find_dependents_of(start, finish, q); x = find_dependents_of(start, finish, q);
if (p == x) { if (p == x) {
sprint_symbol(sym_p, (unsigned long)p->detect); printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %pS depends on %pS and vice-versa. BREAKING IT.\n",
sprint_symbol(sym_q, (unsigned long)q->detect); p->detect, q->detect);
printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %s depends" \
" on %s and vice-versa. BREAKING IT.\n",
sym_p, sym_q);
/* Heavy handed way..*/ /* Heavy handed way..*/
x->depend = 0; x->depend = 0;
} }
@@ -72,12 +66,8 @@ void __init check_iommu_entries(struct iommu_table_entry *start,
for (p = start; p < finish; p++) { for (p = start; p < finish; p++) {
q = find_dependents_of(p, finish, p); q = find_dependents_of(p, finish, p);
if (q && q > p) { if (q && q > p) {
sprint_symbol(sym_p, (unsigned long)p->detect); printk(KERN_ERR "EXECUTION ORDER INVALID! %pS should be called before %pS!\n",
sprint_symbol(sym_q, (unsigned long)q->detect); p->detect, q->detect);
printk(KERN_ERR "EXECUTION ORDER INVALID! %s "\
"should be called before %s!\n",
sym_p, sym_q);
} }
} }
} }