lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[CIFS] Do not log path names in lookup errors

Browse Source 
Andi Kleen noticed that we were logging access denied errors (which is
noisy in the dmesg log, and not needed to be logged) and that we were
logging path names on that an other errors (e.g. EIO) which we should
not be doing.

CC: Andi Kleen <ak@suse.de>
Signed-off-by: Steve French <sfrench@us.ibm.com>
This commit is contained in:
Steve French
2008-01-20 00:30:29 +00:00
parent e6ab15827e
commit ed2b91701d
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fs/cifs/dir.c
View File

@@ -517,12 +517,10 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
d_add(direntry, NULL); d_add(direntry, NULL);
/* if it was once a directory (but how can we tell?) we could do /* if it was once a directory (but how can we tell?) we could do
shrink_dcache_parent(direntry); */ shrink_dcache_parent(direntry); */
} else { } else if (rc != -EACCES) {
cERROR(1, ("Error 0x%x on cifs_get_inode_info in lookup of %s", cERROR(1, ("Unexpected lookup error %d", rc));
rc, full_path)); /* We special case check for Access Denied - since that
/* BB special case check for Access Denied - watch security is a common return code */
exposure of returning dir info implicitly via different rc
if file exists or not but no access BB */
} }
kfree(full_path); kfree(full_path);