lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: BKL removal: vstusb

Browse Source 
BKL was not needed at all. Removed without replacement.

Signed-off-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Oliver Neukum
2010-01-14 16:13:24 +01:00
committed by Greg Kroah-Hartman
parent 3c02b1d79e
commit eedf1f17d4
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/usb/misc/vstusb.c
View File

@@ -27,7 +27,6 @@
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/mutex.h> #include <linux/mutex.h>
#include <linux/smp_lock.h>
#include <linux/uaccess.h> #include <linux/uaccess.h>
#include <linux/usb.h> #include <linux/usb.h>
@@ -104,23 +103,19 @@ static int vstusb_open(struct inode *inode, struct file *file)
struct vstusb_device *vstdev; struct vstusb_device *vstdev;
struct usb_interface *interface; struct usb_interface *interface;
lock_kernel();
interface = usb_find_interface(&vstusb_driver, iminor(inode)); interface = usb_find_interface(&vstusb_driver, iminor(inode));
if (!interface) { if (!interface) {
printk(KERN_ERR KBUILD_MODNAME printk(KERN_ERR KBUILD_MODNAME
": %s - error, can't find device for minor %d\n", ": %s - error, can't find device for minor %d\n",
__func__, iminor(inode)); __func__, iminor(inode));
unlock_kernel();
return -ENODEV; return -ENODEV;
} }
vstdev = usb_get_intfdata(interface); vstdev = usb_get_intfdata(interface);
if (!vstdev) { if (!vstdev)
unlock_kernel();
return -ENODEV; return -ENODEV;
}
/* lock this device */ /* lock this device */
mutex_lock(&vstdev->lock); mutex_lock(&vstdev->lock);
@@ -128,7 +123,6 @@ static int vstusb_open(struct inode *inode, struct file *file)
/* can only open one time */ /* can only open one time */
if ((!vstdev->present) || (vstdev->isopen)) { if ((!vstdev->present) || (vstdev->isopen)) {
mutex_unlock(&vstdev->lock); mutex_unlock(&vstdev->lock);
unlock_kernel();
return -EBUSY; return -EBUSY;
} }
@@ -143,7 +137,6 @@ static int vstusb_open(struct inode *inode, struct file *file)
dev_dbg(&vstdev->usb_dev->dev, "%s: opened\n", __func__); dev_dbg(&vstdev->usb_dev->dev, "%s: opened\n", __func__);
mutex_unlock(&vstdev->lock); mutex_unlock(&vstdev->lock);
unlock_kernel();
return 0; return 0;
} }