ALSA: hda - Fix invalid connections in VT1802 codec
VT1802 codec provides the invalid connection lists of NID 0x24 and 0x33 containing the routes to a non-exist widget 0x3e. This confuses the auto-parser. Fix it up in the driver by overriding these connections. Reported-by: Massimo Del Fedele <max@veneto.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
@@ -3646,6 +3646,18 @@ static const struct snd_pci_quirk vt2002p_fixups[] = {
|
|||||||
{}
|
{}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
/* NIDs 0x24 and 0x33 on VT1802 have connections to non-existing NID 0x3e
|
||||||
|
* Replace this with mixer NID 0x1c
|
||||||
|
*/
|
||||||
|
static void fix_vt1802_connections(struct hda_codec *codec)
|
||||||
|
{
|
||||||
|
static hda_nid_t conn_24[] = { 0x14, 0x1c };
|
||||||
|
static hda_nid_t conn_33[] = { 0x1c };
|
||||||
|
|
||||||
|
snd_hda_override_conn_list(codec, 0x24, ARRAY_SIZE(conn_24), conn_24);
|
||||||
|
snd_hda_override_conn_list(codec, 0x33, ARRAY_SIZE(conn_33), conn_33);
|
||||||
|
}
|
||||||
|
|
||||||
/* patch for vt2002P */
|
/* patch for vt2002P */
|
||||||
static int patch_vt2002P(struct hda_codec *codec)
|
static int patch_vt2002P(struct hda_codec *codec)
|
||||||
{
|
{
|
||||||
@@ -3660,6 +3672,8 @@ static int patch_vt2002P(struct hda_codec *codec)
|
|||||||
spec->aa_mix_nid = 0x21;
|
spec->aa_mix_nid = 0x21;
|
||||||
override_mic_boost(codec, 0x2b, 0, 3, 40);
|
override_mic_boost(codec, 0x2b, 0, 3, 40);
|
||||||
override_mic_boost(codec, 0x29, 0, 3, 40);
|
override_mic_boost(codec, 0x29, 0, 3, 40);
|
||||||
|
if (spec->codec_type == VT1802)
|
||||||
|
fix_vt1802_connections(codec);
|
||||||
add_secret_dac_path(codec);
|
add_secret_dac_path(codec);
|
||||||
|
|
||||||
snd_hda_pick_fixup(codec, NULL, vt2002p_fixups, via_fixups);
|
snd_hda_pick_fixup(codec, NULL, vt2002p_fixups, via_fixups);
|
||||||
|
Reference in New Issue
Block a user