lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

target: Remove unnecessary *cdb transport_get_lun_for_cmd parameter

Browse Source 
This patch removes the now unnecessary 'unsigned char *cdb' function
parameter from transport_get_lun_for_cmd().  This also includes updating
lio-target, tcm_loop and tcm_fc usage of transport_get_lun_for_cmd().

Reported-by: Fubo Chen <fubo.chen@gmail.com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Nicholas Bellinger
2011-07-19 08:09:01 +00:00
parent e434f1f182
commit efa4988d72
4 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/target/loopback/tcm_loop.c
View File

@@ -122,7 +122,7 @@ static struct se_cmd *tcm_loop_allocate_core_cmd(
/* /*
* Locate the struct se_lun pointer and attach it to struct se_cmd * Locate the struct se_lun pointer and attach it to struct se_cmd
*/ */
if (transport_get_lun_for_cmd(se_cmd, NULL, tl_cmd->sc->device->lun) < 0) { if (transport_get_lun_for_cmd(se_cmd, tl_cmd->sc->device->lun) < 0) {
kmem_cache_free(tcm_loop_cmd_cache, tl_cmd); kmem_cache_free(tcm_loop_cmd_cache, tl_cmd);
set_host_byte(sc, DID_NO_CONNECT); set_host_byte(sc, DID_NO_CONNECT);
return NULL; return NULL;

1
drivers/target/target_core_device.c
View File

@@ -56,7 +56,6 @@ static void se_dev_stop(struct se_device *dev);
int transport_get_lun_for_cmd( int transport_get_lun_for_cmd(
struct se_cmd *se_cmd, struct se_cmd *se_cmd,
unsigned char *cdb,
u32 unpacked_lun) u32 unpacked_lun)
{ {
struct se_dev_entry *deve; struct se_dev_entry *deve;

2
drivers/target/tcm_fc/tfc_cmd.c
View File

@@ -637,7 +637,7 @@ static void ft_send_cmd(struct ft_cmd *cmd)
fc_seq_exch(cmd->seq)->lp->tt.seq_set_resp(cmd->seq, ft_recv_seq, cmd); fc_seq_exch(cmd->seq)->lp->tt.seq_set_resp(cmd->seq, ft_recv_seq, cmd);
cmd->lun = scsilun_to_int((struct scsi_lun *)fcp->fc_lun); cmd->lun = scsilun_to_int((struct scsi_lun *)fcp->fc_lun);
ret = transport_get_lun_for_cmd(&cmd->se_cmd, NULL, cmd->lun); ret = transport_get_lun_for_cmd(&cmd->se_cmd, cmd->lun);
if (ret < 0) { if (ret < 0) {
ft_dump_cmd(cmd, __func__); ft_dump_cmd(cmd, __func__);
transport_send_check_condition_and_sense(&cmd->se_cmd, transport_send_check_condition_and_sense(&cmd->se_cmd,

2
include/target/target_core_device.h
View File

@@ -1,7 +1,7 @@
#ifndef TARGET_CORE_DEVICE_H #ifndef TARGET_CORE_DEVICE_H
#define TARGET_CORE_DEVICE_H #define TARGET_CORE_DEVICE_H
extern int transport_get_lun_for_cmd(struct se_cmd *, unsigned char *, u32); extern int transport_get_lun_for_cmd(struct se_cmd *, u32);
extern int transport_get_lun_for_tmr(struct se_cmd *, u32); extern int transport_get_lun_for_tmr(struct se_cmd *, u32);
extern struct se_dev_entry *core_get_se_deve_from_rtpi( extern struct se_dev_entry *core_get_se_deve_from_rtpi(
struct se_node_acl *, u16); struct se_node_acl *, u16);