lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] bcm43xx: output proper link quality with scans

Browse Source 
The bcm43xx-softmac driver fails to set two quantities needed for
iwlist to compute wireless quality when scanning. As a result, userland
programs using the quality to determine the best connection fail.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Larry Finger
2006-09-25 15:33:20 -05:00
committed by Jeff Garzik
parent 3470cb1d4f
commit f04e2be7d9
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/wireless/bcm43xx/bcm43xx.h
View File

@@ -365,6 +365,9 @@
#define BCM43xx_DEFAULT_SHORT_RETRY_LIMIT 7 #define BCM43xx_DEFAULT_SHORT_RETRY_LIMIT 7
#define BCM43xx_DEFAULT_LONG_RETRY_LIMIT 4 #define BCM43xx_DEFAULT_LONG_RETRY_LIMIT 4
/* FIXME: the next line is a guess as to what the maximum RSSI value might be */
#define RX_RSSI_MAX 60
/* Max size of a security key */ /* Max size of a security key */
#define BCM43xx_SEC_KEYSIZE 16 #define BCM43xx_SEC_KEYSIZE 16
/* Security algorithms. */ /* Security algorithms. */

2
drivers/net/wireless/bcm43xx/bcm43xx_main.c
View File

@@ -3688,6 +3688,8 @@ static int bcm43xx_read_phyinfo(struct bcm43xx_private *bcm)
phy_type); phy_type);
return -ENODEV; return -ENODEV;
}; };
bcm->ieee->perfect_rssi = RX_RSSI_MAX;
bcm->ieee->worst_rssi = 0;
if (!phy_rev_ok) { if (!phy_rev_ok) {
printk(KERN_WARNING PFX "Invalid PHY Revision %x\n", printk(KERN_WARNING PFX "Invalid PHY Revision %x\n",
phy_rev); phy_rev);

3
drivers/net/wireless/bcm43xx/bcm43xx_wx.c
View File

@@ -47,9 +47,6 @@
#define BCM43xx_WX_VERSION 18 #define BCM43xx_WX_VERSION 18
#define MAX_WX_STRING 80 #define MAX_WX_STRING 80
/* FIXME: the next line is a guess as to what the maximum RSSI value might be */
#define RX_RSSI_MAX 60
static int bcm43xx_wx_get_name(struct net_device *net_dev, static int bcm43xx_wx_get_name(struct net_device *net_dev,
struct iw_request_info *info, struct iw_request_info *info,