[PATCH] fs: use list_move()
This patch converts the combination of list_del(A) and list_add(A, B) to list_move(A, B) under fs/. Cc: Ian Kent <raven@themaw.net> Acked-by: Joel Becker <joel.becker@oracle.com> Cc: Neil Brown <neilb@cse.unsw.edu.au> Cc: Hans Reiser <reiserfs-dev@namesys.com> Cc: Urban Widmark <urban@teststation.com> Acked-by: David Howells <dhowells@redhat.com> Acked-by: Mark Fasheh <mark.fasheh@oracle.com> Signed-off-by: Akinobu Mita <mita@miraclelinux.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
committed by
Linus Torvalds
parent
179e09172a
commit
f116629d03
@ -400,8 +400,7 @@ static int smb_request_send_req(struct smb_request *req)
|
||||
if (!(req->rq_flags & SMB_REQ_TRANSMITTED))
|
||||
goto out;
|
||||
|
||||
list_del_init(&req->rq_queue);
|
||||
list_add_tail(&req->rq_queue, &server->recvq);
|
||||
list_move_tail(&req->rq_queue, &server->recvq);
|
||||
result = 1;
|
||||
out:
|
||||
return result;
|
||||
@ -435,8 +434,7 @@ int smb_request_send_server(struct smb_sb_info *server)
|
||||
result = smb_request_send_req(req);
|
||||
if (result < 0) {
|
||||
server->conn_error = result;
|
||||
list_del_init(&req->rq_queue);
|
||||
list_add(&req->rq_queue, &server->xmitq);
|
||||
list_move(&req->rq_queue, &server->xmitq);
|
||||
result = -EIO;
|
||||
goto out;
|
||||
}
|
||||
|
@ -193,8 +193,7 @@ int smbiod_retry(struct smb_sb_info *server)
|
||||
if (req->rq_flags & SMB_REQ_RETRY) {
|
||||
/* must move the request to the xmitq */
|
||||
VERBOSE("retrying request %p on recvq\n", req);
|
||||
list_del(&req->rq_queue);
|
||||
list_add(&req->rq_queue, &server->xmitq);
|
||||
list_move(&req->rq_queue, &server->xmitq);
|
||||
continue;
|
||||
}
|
||||
#endif
|
||||
|
Reference in New Issue
Block a user